Skip to content

Tests: show any and all actual/expected values #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmywil merged 1 commit into from
Mar 15, 2024
Merged

Tests: show any and all actual/expected values #5448

timmywil merged 1 commit into from
Mar 15, 2024

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Mar 15, 2024

Summary

  • Show actual and expected values even if they are falsey.
  • Also leave out message if none was provided, rather than printing undefined.

Checklist

@timmywil timmywil added the Tests label Mar 15, 2024
@timmywil timmywil added this to the 4.0.0 milestone Mar 15, 2024
@timmywil timmywil requested a review from mgol March 15, 2024 20:50
@timmywil timmywil mentioned this pull request Mar 15, 2024
Merged
2 tasks
mgol
mgol approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timmywil timmywil merged commit f80e78e into jquery:main Mar 15, 2024
@timmywil timmywil deleted the actual branch March 15, 2024 21:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mgol mgol mgol approved these changes

Assignees

No one assigned

Labels

Tests

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@timmywil @mgol