Skip to content

Tests: add diffing to test reporter #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Tests: add diffing to test reporter #5445

merged 1 commit into from
Mar 14, 2024

Conversation

timmywil
Copy link
Member

Summary

Add diffing to test reporter.

This idea came from QUnit, but I added special diffing for when the values are numbers.

Checklist

@timmywil timmywil requested a review from mgol March 14, 2024 13:48
@timmywil timmywil added the Tests label Mar 14, 2024
@timmywil timmywil added this to the 4.0.0 milestone Mar 14, 2024
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show an example of an array, object & number failure with the implementation from this PR?

@timmywil
Copy link
Member Author

timmywil commented Mar 14, 2024

Objects

image

Arrays

image

Strings

image

Numbers

image

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@timmywil timmywil merged commit 44fb7fa into jquery:main Mar 14, 2024
@timmywil timmywil deleted the diff branch March 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants