Tests: add actual and expected messages to test reporter #5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mgol
approved these changes
Mar 14, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
Approving but I'd love to see proper diffing in the console; sometimes it can really help.
Comment on lines
+26
to
+27
| message += `\nexpected: ${ JSON.stringify( error.expected ) }`; | ||
| message += `\nactual: ${ chalk.red( JSON.stringify( error.actual ) ) }`; |
Member
There was a problem hiding this comment.
Could we also do a diff? It can be helpful when comparing objects. It's quite easy to do with the diff package; a colored example: https://www.npmjs.com/package/diff#basic-example-in-node
Member
There was a problem hiding this comment.
BTW, feel free to tackle this in a separate PR; it may even be cleaner to have the diffing feature in a separate commit on main.
Member
Author
There was a problem hiding this comment.
Sure, we'll do that in another PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the actual and expected messages to the reporter.
Also, I realized that
test.errorscontained all the failed assertions andtest.assertionscontained only passed ones, so I was able to clean up that code a bit.Checklist