Skip to content

Tests: add --hard-retries option to test runner #5438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Mar 10, 2024

Summary

Add the ability to retry by restarting the worker and getting a different browser instance, after all normal retries have been exhausted. This can sometimes be successful for flakey tests when a refresh is not.

Checklist

Sorry, something went wrong.

- Add the ability to retry by restarting the worker and
  getting a different browser instance, after all
  normal retries have been exhausted. This can sometimes
  be successful when a refresh is not.
@timmywil timmywil added the Tests label Mar 10, 2024
@timmywil timmywil added this to the 4.0.0 milestone Mar 10, 2024
@timmywil timmywil requested a review from mgol March 10, 2024 15:54
"</head>",
"<script src=\"/test/runner/listeners.js\"></script></head>"
)
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran prettier on this file.

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by reading with one question

return true;
}
}
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retryTest, the test (or undefined) is returned; here: a boolean or undefined. Is this difference intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly yes, but this function should return boolean.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@timmywil timmywil merged commit 822362e into jquery:main Mar 11, 2024
@timmywil timmywil deleted the hard-retry branch March 11, 2024 14:39
@timmywil timmywil mentioned this pull request Mar 11, 2024
2 tasks
@timmywil
Copy link
Member Author

I accidentally broke worker restarts for when the browser fails the acknowledgement test. I've added a fix for it to #5440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants