Drop support for Node 10 #5436
Merged
Drop support for Node 10 #5436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mgol
approved these changes
Mar 9, 2024
| const path = require( "path" ); | ||
| const util = require( "util" ); | ||
| const exec = util.promisify( require( "child_process" ).exec ); | ||
| const fs = require( "node:fs/promises" ); |
Member
There was a problem hiding this comment.
Not for this PR but maybe we could eventually make all our Node build files ESM instead of CommonJS?
Member
Author
There was a problem hiding this comment.
Maybe that's something I could tackle in the release PR.
mgol
reviewed
Mar 9, 2024
| "express-body-parser-error-handler": "1.0.7", | ||
| "globals": "14.0.0", | ||
| "husky": "8.0.3", | ||
| "husky": "9.0.11", |
Member
There was a problem hiding this comment.
On the 3.x PR, you also changed husky install to husky. Isn't that required here as well?
Member
Author
There was a problem hiding this comment.
Thanks, I meant to do that. Both technically work, but the first is deprecated.
timmywil
force-pushed
the
node-10
branch
2 times, most recently
from
c987cbd to
08f1b40
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist