-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Drop support for Node 10 #5436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Node 10 #5436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const path = require( "path" ); | ||
const util = require( "util" ); | ||
const exec = util.promisify( require( "child_process" ).exec ); | ||
const fs = require( "node:fs/promises" ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR but maybe we could eventually make all our Node build files ESM instead of CommonJS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that's something I could tackle in the release PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, one comment
"express-body-parser-error-handler": "1.0.7", | ||
"globals": "14.0.0", | ||
"husky": "8.0.3", | ||
"husky": "9.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the 3.x PR, you also changed husky install
to husky
. Isn't that required here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I meant to do that. Both technically work, but the first is deprecated.
c987cbd
to
08f1b40
Compare
Summary
Checklist