Build: add GitHub Actions workflow to update Filestash #5434
Conversation
|
The following look great:
The following could tighten it further:
Neither a big deals. LGTM as-is. |
|
The first suggestion sounds good to me, but I prefer to have control and consistency over the Node version everywhere we build. I've learned not to trust whatever Node version comes preinstalled in the runner image. We've been bitten by that before, and I don't want to be at the mercy of the image's update schedule. FWIW, that step usually takes less than a second and is the same for all workflows that build. |
|
I've applied "protected branches only" to the environment, which includes |
There was a problem hiding this comment.
LGTM. Let me know when you're ready to merge so that I disable the Jenkins job.
One thing - with the Jenkins job being disabled before merging this, we no longer need to build on Node.js 10. You can remove it here if you want. That said, dropping Node 10 allows us to introduce a few improvements like upgrade Rollup (which I need for the exports improvements PR), switch to node:-prefixed Node.js core modules, using node:fs/promises instead of fs.promises from node:fs, dropping the jenkins npm script and maybe something else. If you'd like, you can group it all in a followup PR. I'd just prefer not to wait too long with dropping the build on Node 10.
|
Thanks for making a list. I'll make those changes in a followup PR. |
|
Checked all files and they all updated as expected. |
Summary
Replaces the jenkins workflow to update git versions of jQuery on the Filestash server. The filestash environment is already set up in the jQuery repo settings and includes the necessary SSH private key and filestash server URL.
Here's a sample of the workflow running as a dry run:
https://github.com/timmywil/jquery/actions/runs/8205613186/job/22442850764
We should disable the jenkins workflow before merging.
Checklist