Tests: fix flakey message logs; ignore delete worker failures #5431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ghost
approved these changes
Mar 5, 2024
|
|
||
| // Show a message for flakey tests | ||
| if ( existing ) { | ||
| console.log(); |
There was a problem hiding this comment.
What's the reason for these empty console.logs?
Member
Author
There was a problem hiding this comment.
Just to add newlines. I could instead add \n to the start and end of the message, but with the message starting with a variable, I figured this was cleaner than adding "\n" + .
Member
Author
There was a problem hiding this comment.
I'm going to assume you're okay with that. We can always change in a subsequent PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add some minor improvements after watching the recent first run on 3.x-stable, including:
Checklist