Release: use buildDefaultFiles directly and pass version #5408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
commented
Feb 5, 2024
- also add the ability to pass VERSION in env to test final builds - adjust sha regex to account for lack of shas - set the version on the dist package.json
timmywil
force-pushed
the
release-build
branch
from
2228084 to
7a1d3cf
Compare
timmywil
commented
Feb 5, 2024
timmywil
commented
Feb 5, 2024
timmywil
commented
Feb 5, 2024
mgol
reviewed
Feb 5, 2024
mgol
approved these changes
Feb 6, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
One non-blocking question about the logic which is more me trying to understand the code flow here & before. LGTM!
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Feb 6, 2024
- also add the ability to pass VERSION in env to test final builds - adjust sha regex to account for lack of shas - set the version on the dist package.json Close jquerygh-5408
2 tasks
timmywil
added a commit
that referenced
this pull request
Feb 6, 2024
- also add the ability to pass VERSION in env to test final builds - adjust sha regex to account for lack of shas - set the version on the dist package.json Close gh-5408
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist