Skip to content

Data: Refactor to reduce size #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmywil merged 1 commit into from
Jan 23, 2024
Merged

Data: Refactor to reduce size #5392

timmywil merged 1 commit into from
Jan 23, 2024

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented Jan 17, 2024

  • Return the new value from set(owner, key, value).
  • Use set(owner, key, value) rather than access(owner, key, value).

Summary

Improvements noticed in passing.

main @88690ebfc8b5ef8b1e444326c664b590ecc0b888
   raw     gz Filename
   -44    -17 dist/jquery.min.js
   -35    -16 dist/jquery.slim.min.js
   -44    -21 dist-module/jquery.module.min.js
   -35    -15 dist-module/jquery.slim.module.min.js

Checklist

@gibson042
Data: Refactor to reduce size
d1b0b59 
* Return the new value from `set(owner, key, value)`.
* Use `set(owner, key, value)` rather than `access(owner, key, value)`.
timmywil
timmywil approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@timmywil timmywil merged commit 805cdb4 into jquery:main Jan 23, 2024
@timmywil timmywil added this to the 4.0.0 milestone Feb 6, 2024
@timmywil timmywil added the Data label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

No one assigned

Labels

Data

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gibson042 @timmywil