Skip to content

Manipulation: Generalize a test to support IE #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

Manipulation: Generalize a test to support IE #5391

merged 1 commit into from
Jan 12, 2024

Conversation

gibson042
Copy link
Member

Ref gh-5378

Summary

Work around the lack of document.currentScript with explicit IDs.

Checklist

Sorry, something went wrong.

@gibson042 gibson042 requested a review from mgol January 12, 2024 16:06
mgol
mgol approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgol mgol merged commit 88690eb into jquery:main Jan 12, 2024
mgol pushed a commit that referenced this pull request Jan 12, 2024
@gibson042 @mgol
Manipulation: Generalize a test to support IE
ab0444d 
Ref gh-5378
Closes gh-5391

(cherry picked from commit 88690eb)
@mgol mgol added this to the 3.7.2 milestone Jan 12, 2024
@mgol
Copy link
Member

mgol commented Jan 12, 2024

Landed on main in 88690eb & on 3.x-stable in ab0444d. TestSwarm is green after this merge on both branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol

Assignees
No one assigned
Labels
Manipulation
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gibson042 @mgol