Selector: Eliminate selector.js depenencies from various modules
#5383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two main reasons for why some of those dependencies are no longer needed: 1. `jQuery.contains` which is now a part of `core`. 2. `jQuery.find.attr` no longer exists, native `getAttribute` is used instead.
gibson042
approved these changes
Jan 3, 2024
Member
Author
|
This change should not be controversial so I'm going to merge it with 1 approval. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are two main reasons for why some of those dependencies are no longer needed:
jQuery.containswhich is now a part ofcore.jQuery.find.attrno longer exists, nativegetAttributeis used instead.Checklist