Manipulation: Support $el.html(selfRemovingScript) #5378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Jan 8, 2024
mgol
pushed a commit
to mgol/jquery
that referenced
this pull request
Jan 8, 2024
Don't try to remove a script element that has already removed itself. Fixes jquerygh-5377 Closes jquerygh-5378 (cherry-picked from commit 937923d)
Member
gibson042
added a commit
to gibson042/jquery
that referenced
this pull request
Jan 12, 2024
2 tasks
mgol
pushed a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-5377
Summary
Don't try to remove a script element that has already removed itself.
With nearby improvements, +12 bytes to jquery.min.js (+1 gzipped).
Checklist