Skip to content

Build: Update ESLint-related packages, fix linting errors (3.x version) #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 16, 2023

Summary

The main change is the new rule in eslint-config-jquery: template-curly-spacing.

4.x version of this PR: gh-5347.

Ref jquery/eslint-config-jquery#21
Ref gh-5347

Checklist

Sorry, something went wrong.

The main change is the new rule in `eslint-config-jquery`:
`template-curly-spacing`.

Ref jquery/eslint-config-jquery#21
Ref jquerygh-5347
@mgol mgol added this to the 3.7.2 milestone Oct 16, 2023
@mgol mgol self-assigned this Oct 16, 2023
mgol added a commit to mgol/jquery that referenced this pull request Oct 16, 2023
The main change is the new rule in `eslint-config-jquery`:
`template-curly-spacing`.

Ref jquery/eslint-config-jquery#21
Ref jquerygh-5348
@mgol mgol requested a review from timmywil October 30, 2023 17:10
@mgol
Copy link
Member Author

mgol commented Nov 1, 2023

The only test failure is the Chrome 117/118 bug fixed in Chrome 119, merging despite the failure.

@mgol mgol merged commit e84886a into jquery:3.x-stable Nov 1, 2023
@mgol mgol deleted the 3.x-eslint-update branch November 1, 2023 23:48
@mgol mgol removed the Needs review label Nov 1, 2023
mgol added a commit that referenced this pull request Nov 1, 2023
The main change is the new rule in `eslint-config-jquery`:
`template-curly-spacing`.

Closes gh-5347
Ref jquery/eslint-config-jquery#21
Ref gh-5348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants