Build: fix inconsistent builds in Node 20 #5332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
commented
Sep 20, 2023
| ...inputOptions, | ||
| plugins: [ rollupFileOverrides( fileOverrides ) ] | ||
| } ); | ||
|
|
There was a problem hiding this comment.
I moved this here as it's not needed if watching.
timmywil
commented
Sep 20, 2023
| - name: Lint code | ||
| run: npm run lint | ||
| run: npm run build:all && npm run lint |
There was a problem hiding this comment.
The removed build above was only the first build on Node 20, but I think any of them could have failed. But, I realized lint only runs on Node 18.x, so I moved it there.
- one fileOverrides per build - only run the lint build when running lint Close jquerygh-5332
mgol
approved these changes
Sep 20, 2023
timmywil
added a commit
that referenced
this pull request
Sep 20, 2023
- one fileOverrides per build - only run the lint build when running lint Close gh-5332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist