Build: Generate the slim build on grunt & run compare_size on it
#5291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of the changes: * expand `node_smoke_tests` to test the full & slim builds * run `compare_size` on all built minified files; don't run it anymore on unminified files where they don't provide lots of value The main goal of this change is to make it easier to compare sizes of both the full & slim builds between the `3.x-stable` & `main` branches. Ref jquerygh-5255 (partially cherry-picked from commit 8be4c0e)
mgol
added
Needs review
Build
Discuss in Meeting
timmywil
approved these changes
Jul 10, 2023
mgol
removed
Discuss in Meeting
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary of the changes:
node_smoke_teststo test the full & slim buildscompare_sizeon all built minified files; don't run it anymore on unminified files where they don't provide lots of valueThe main goal of this change is to make it easier to compare sizes of both the full & slim builds between the
3.x-stable&mainbranches.Ref gh-5255
(partially cherry-picked from commit 8be4c0e)
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com