Build: Switch form Terser to SWC for JS minification #5286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, as part of this, fix the `file` & `sources` properties of the source map file. Fixes jquerygh-5285 Ref jquerygh-5258
mgol
added
Needs review
Build
Discuss in Meeting
mgol
commented
Jul 6, 2023
Comment on lines
+41
to
+47
| // Apply map overrides if needed. See the task config description | ||
| // for more details. | ||
| const mapObject = { | ||
| ...JSON.parse( incompleteMap ), | ||
| ...sourceMapOverrides | ||
| }; | ||
| const map = JSON.stringify( mapObject ); |
Member
Author
There was a problem hiding this comment.
I wish we could avoid this parse + fix + stringify back behavior, but it's still quick enough (I actually cannot measure a meaningful time difference with & without this code) and there's not much we can do until the issues are fixed or I learn which parameters to use to get what we need out of the box.
timmywil
approved these changes
Jul 10, 2023
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
I forget now why we were reticent to switch to swc, but this looks good.
Member
Author
It used to not support the preamble option - and inserting it manually would require source map adjustments which is not something I'd like to do on our end. They added support after my report in swc-project/swc#7475. |
timmywil
removed
the
Discuss in Meeting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also, as part of this, fix the
file&sourcesproperties of the source map file.Fixes gh-5285
Ref gh-5258
-18 bytes
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com