Selector: Only attach the unload handler in IE & Edge Legacy #5282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both IE & Edge Legacy need the workaround of calling `setDocument()` in an `unload` handler to avoid "permission denied" errors. However, due to not being possible to feature-detect this issue, the handler has been applied in all browsers for windows different than the one in which jQuery was loaded. jQuery 4.0, which drops Edge Legacy support, guards this workaround with a `document.documentMode` check. This won't work in the 3.x line due to still supporting Edge Legacy but we can check for `document.documentElement.msMatchesSelector` instead as that API is supported in IE 9+ and all Edge Legacy versions. Fixes jquerygh-5281 Ref jquerygh-4792
mgol
added
Selector
Needs review
Discuss in Meeting
Member
Author
|
Test case showing all supported aliases of |
timmywil
approved these changes
Jul 10, 2023
timmywil
removed
the
Discuss in Meeting
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both IE & Edge Legacy need the workaround of calling
setDocument()in anunloadhandler to avoid "permission denied" errors. However, due to not being possible to feature-detect this issue, the handler has been applied in all browsers for windows different than the one in which jQuery was loaded.jQuery 4.0, which drops Edge Legacy support, guards this workaround with a
document.documentModecheck. This won't work in the 3.x line due to still supporting Edge Legacy but we can check fordocument.documentElement.msMatchesSelectorinstead as that API is supported in IE 9+ and all Edge Legacy versions.Fixes gh-5281
Ref gh-4792
+6 bytes
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com