Build: Switch the minifier from UglifyJS to Terser #5258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UglifyJS is ES5-only, while Terser supports newer ECMAScript versions. jQuery is authored in ES5 but jQuery 4.x will also have an ESM build that cannot be minified using UglifyJS directly. We could strip the `export` statement, minify via UglifyJS and re-add one but that increases complexity & may not fully play nice with source maps. On the other hand, switching to Terser increases the minfied size by just 324 bytes and the minified gzipped one by just 70 bytes. Such differences largely disappear among bigger size gains from the `3.x-stable` line - around 2.7 KB minified gzipped as of now.
mgol
added
Needs review
Build
Discuss in Meeting
Member
Author
|
This is a pre-requisite to finalizing the |
gibson042
approved these changes
May 25, 2023
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
I'm in favor of this, but it supports my suspicion that Terser is not as good as Uglify w.r.t. output compressibility.
Member
Author
|
@gibson042 Yes, although it got better in the past year. Last time I was testing with Terser I also think it may be a good idea to compare the output of UglifyJS & Terser in more detail and work with Terser maintainers to improve it, getting closer to UglifyJS. But I wouldn't treat this as a blocker for this PR, just ground for possible future optimizations. |
mgol
removed
Needs review
Discuss in Meeting
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 27, 2023
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 6, 2023
Also, as part of this, fix the `file` & `sources` properties of the source map file. Fixes jquerygh-5285 Ref jquerygh-5258
mgol
added a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UglifyJS is ES5-only, while Terser supports newer ECMAScript versions. jQuery is authored in ES5 but jQuery 4.x will also have an ESM build that cannot be minified using UglifyJS directly.
We could strip the
exportstatement, minify via UglifyJS and re-add one but that increases complexity & may not fully play nice with source maps.On the other hand, switching to Terser increases the minfied size by just 324 bytes and the minified gzipped one by just 70 bytes. Such differences largely disappear among bigger size gains from the
3.x-stableline - around 2.7 KB minified gzipped as of now.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com