Skip to content

CSS: Add missing jQuery.cssNumber entries #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 2 commits into from
Mar 27, 2023
Merged

CSS: Add missing jQuery.cssNumber entries #5233

mgol merged 2 commits into from
Mar 27, 2023

Conversation

@mgol
Copy link
Member

@mgol mgol commented Mar 27, 2023 •
edited by Krinkle
Loading

Summary

This covers aspect-ratio, scale, and a few others.

A few properties have been taken from React:
https://github.com/facebook/react/blob/afea1d0c536e0336735b0ea5c74f635527b65785/packages/react-dom-bindings/src/shared/CSSProperty.js#L8-L58

Fixes gh-5179

The summary of my changes:

  1. Removed quotes
  2. Copied the list from React
  3. Removed non-standard (?) APIs:
    1. flexNegative
    2. flexOrder
    3. flexPositive
    4. gridColumnSpan
    5. gridRowSpan
  4. Removed the old flex API:
    1. boxFlex
    2. boxFlexGroup
  5. Removed because they accept px as well (so adding them would be a breaking change):
    1. borderImageOutset
    2. borderImageWidth
    3. columns
    4. flex
    5. tabSize
    6. strokeDasharray
    7. strokeDashoffset
    8. strokeWidth
  6. Removed because only prefixed available & non-prefixed version - if available - unstable:
    1. boxOrdinalGroup
    2. lineClamp

Also, unquote keys in jQuery.cssNumber - this was done in the first commit for easier review.

+53 bytes

Checklist

@mgol mgol added CSS Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Mar 27, 2023
@mgol mgol added this to the 3.7.0 milestone Mar 27, 2023
@mgol mgol self-assigned this Mar 27, 2023
@mgol mgol mentioned this pull request Mar 27, 2023
Closed
@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Mar 27, 2023
timmywil
timmywil approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol removed the Needs review label Mar 27, 2023
@mgol mgol merged commit 3eed282 into jquery:3.x-stable Mar 27, 2023
@mgol mgol deleted the 3.x-css-number-updates branch March 27, 2023 19:50
mgol added a commit that referenced this pull request Mar 27, 2023
@mgol
Tests: Fix tests added in gh-5233
759232e
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

CSS

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil