Tests: Indicate Chrome 112 & Safari 16.4 pass the cssHas support test (3.x version) #5226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
changed the title
mgol
force-pushed
the
3.x-chrome-cssHas-support
branch
from
a06cce8 to
74e0734
Compare
1 task
mgol
added
the
Discuss in Meeting
timmywil
approved these changes
Mar 27, 2023
mgol
force-pushed
the
3.x-chrome-cssHas-support
branch
from
74e0734 to
0c59578
Compare
mgol
removed
Discuss in Meeting
Member
Author
|
I'll wait with merging this until Chrome 112 stable gets released to make sure relevant Chrome changes stay enabled on the stable channel. |
Member
Author
|
Chrome 112 is out and it passes the test so I'm merging the PR. |
mgol
changed the title
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Apr 4, 2023
Chrome 112 & Safari 16.4 introduce two changes: * `:has()` is non-forgiving * `CSS.supports( "selector(...)" )` parses everything in a non-forgiving way We no longer care about the latter but the former means the `cssHas` support test now passes. Closes jquerygh-5226
mgol
force-pushed
the
3.x-chrome-cssHas-support
branch
from
0c59578 to
636dcf6
Compare
Member
Author
|
I also added updates for Safari: version 16.4 now passes the |
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Apr 4, 2023
Chrome 112 & Safari 16.4 introduce two changes: * `:has()` is non-forgiving * `CSS.supports( "selector(...)" )` parses everything in a non-forgiving way We no longer care about the latter but the former means the `cssHas` support test now passes. Closes jquerygh-5226
mgol
force-pushed
the
3.x-chrome-cssHas-support
branch
from
636dcf6 to
00b87e9
Compare
Chrome 112 & Safari 16.4 introduce two changes: * `:has()` is non-forgiving * `CSS.supports( "selector(...)" )` parses everything in a non-forgiving way We no longer care about the latter but the former means the `cssHas` support test now passes. Closes jquerygh-5226
mgol
force-pushed
the
3.x-chrome-cssHas-support
branch
from
00b87e9 to
1f60397
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 112 & Safari 16.4 introduce two changes:
:has()is non-forgivingCSS.supports( "selector(...)" )parses everything in a non-forgiving wayWe no longer care about the latter but the former means the
cssHassupport test now passes.mainversion: #5225Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com