Tests: Indicate Chrome 112 & Safari 16.4 pass the cssHas support test #5225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
chrome-cssHas-support
branch
from
ee76177 to
3d8a2e6
Compare
1 task
mgol
added
the
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Mar 27, 2023
mgol
force-pushed
the
chrome-cssHas-support
branch
from
3d8a2e6 to
3ab45df
Compare
Member
Author
|
I'll wait with merging this until Chrome 112 stable gets released to make sure relevant Chrome changes stay enabled on the stable channel. |
Member
Author
|
Chrome 112 is out and it passes the test so I'm merging the PR. |
mgol
changed the title
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Apr 4, 2023
Chrome 112 & Safari 16.4 introduce two changes: * `:has()` is non-forgiving * `CSS.supports( "selector(...)" )` parses everything in a non-forgiving way We no longer care about the latter but the former means the `cssHas` support test now passes. Closes jquerygh-5225
mgol
force-pushed
the
chrome-cssHas-support
branch
from
3ab45df to
a8b0b3e
Compare
Member
Author
|
I also added updates for Safari: version 16.4 now passes the |
Chrome 112 & Safari 16.4 introduce two changes: * `:has()` is non-forgiving * `CSS.supports( "selector(...)" )` parses everything in a non-forgiving way We no longer care about the latter but the former means the `cssHas` support test now passes. Closes jquerygh-5225
mgol
force-pushed
the
chrome-cssHas-support
branch
from
a8b0b3e to
449c046
Compare
mgol
added a commit
that referenced
this pull request
Apr 4, 2023
Chrome 112 & Safari 16.4 introduce two changes: * `:has()` is non-forgiving * `CSS.supports( "selector(...)" )` parses everything in a non-forgiving way We no longer care about the latter but the former means the `cssHas` support test now passes. Closes gh-5225
Member
Author
|
Landed on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 112 & Safari 16.4 introduce two changes:
:has()is non-forgivingCSS.supports( "selector(...)" )parses everything in a non-forgiving wayWe no longer care about the latter but the former means the
cssHassupport test now passes.3.x-stableversion: #5226Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com