Skip to content

Release: add support for md5 sums in windows #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Mar 7, 2023

Summary

I wanted to see if the release could be run on Windows. To my surprise, the md5 hash was the only thing that didn't work.

This checks the OS and switches up the command used for the md5 sums and formats it the same way as default mac/linux.

Checklist

@timmywil timmywil requested a review from mgol March 7, 2023 21:28
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one style suggestion. I assume this is to be cherry-picked to main & 3.x-stable as well.

Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
@timmywil timmywil merged commit 25ee194 into jquery:3.6-stable Mar 8, 2023
@timmywil timmywil deleted the windows-release branch March 8, 2023 15:15
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 8, 2023
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 8, 2023
@mgol mgol added the Release label Mar 8, 2023
@mgol mgol added this to the 3.6.4 milestone Mar 8, 2023
@jquery jquery deleted a comment from Kristianko1995 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants