Deferred: Rename getStackHook to getErrorHook (3.x version)
#5212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Feb 15, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `3.7.0` version; PR jquerygh-5211 implements the `4.0.0` one. Fixes jquerygh-5201 Closes jquerygh-5212 Ref jquerygh-5211
mgol
force-pushed
the
3.x-get-error-hook
branch
from
dc2f3cf to
8522221
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Feb 15, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `4.0.0` version; PR jquerygh-5212 implements the `3.7.0` one. Fixes jquerygh-5201 Closes jquerygh-5211 Ref jquerygh-5212
This was referenced Feb 15, 2023
mgol
changed the title
getStackHook to getErrorHookgetStackHook to getErrorHook (3.x version)
dmethvin
approved these changes
Feb 24, 2023
mgol
added
the
Discuss in Meeting
timmywil
approved these changes
Mar 13, 2023
timmywil
removed
the
Discuss in Meeting
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `3.7.0` version; PR jquerygh-5211 implements the `4.0.0` one. Fixes jquerygh-5201 Closes jquerygh-5212 Ref jquerygh-5211
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Mar 14, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `4.0.0` version; PR jquerygh-5212 implements the `3.7.0` one. Fixes jquerygh-5201 Closes jquerygh-5211 Ref jquerygh-5212
mgol
force-pushed
the
3.x-get-error-hook
branch
from
8522221 to
bc19320
Compare
mgol
added a commit
that referenced
this pull request
Mar 14, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `4.0.0` version; PR gh-5212 implements the `3.7.0` one. Fixes gh-5201 Closes gh-5211 Ref gh-5212
mgol
added a commit
that referenced
this pull request
Mar 15, 2023
The non-deprecated test was already skipped there, the deprecated one is now skipped as well. Ref gh-5212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
jQuery.Deferred.getStackHooktojQuery.Deferred.getErrorHookto indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not.In jQuery
3.7.0, we'll keep both names, marking the old one as deprecated. In jQuery4.0.0we'll just keep the new one. This change implements the3.7.0version; PR gh-5211 implements the4.0.0one.Fixes gh-5201
Ref gh-5211
Checklist