Skip to content

Selector: Rename rcombinators to rleadingCombinator #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Feb 13, 2023
Merged

Selector: Rename rcombinators to rleadingCombinator #5208

mgol merged 1 commit into from
Feb 13, 2023

Conversation

@mgol
Copy link
Member

@mgol mgol commented Feb 13, 2023

Summary

Checklist

@mgol mgol added Selector Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Feb 13, 2023
@mgol mgol added this to the 3.7.0 milestone Feb 13, 2023
@mgol mgol self-assigned this Feb 13, 2023
@mgol mgol mentioned this pull request Feb 13, 2023
Merged
3 tasks
timmywil
timmywil approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@timmywil timmywil removed Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Feb 13, 2023
gibson042
gibson042 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgol mgol merged commit ac1c59a into jquery:3.x-stable Feb 13, 2023
@mgol mgol deleted the 3.x-rcombinators-renaming branch February 13, 2023 17:35
mgol added a commit to jquery/sizzle that referenced this pull request Feb 13, 2023
@mgol
Selector: Rename rcombinators to rleadingCombinator
248b59c 
Closes gh-494
Ref jquery/jquery#5186
Ref jquery/jquery#5208
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

@gibson042 gibson042 gibson042 approved these changes

Assignees

@mgol mgol

Labels

Selector

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mgol @timmywil @gibson042