Build: Only install Playwright dependencies when needed #5204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR jquerygh-5190 added support for running tests on Playwright WebKit in CI. For efficiency reasons, Playwright dependencies are only installed for the `test:browser` npm script. However, that same script is also used for Firefox ESR testing. This change makes Playwright dependencies installed only for cases where `WebKitHeadless` exists on the list of tested browsers. Ref jquerygh-5190
mgol
added
the
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Mar 20, 2023
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
I like the added flexibility
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Mar 20, 2023
PR jquerygh-5190 added support for running tests on Playwright WebKit in CI. For efficiency reasons, Playwright dependencies are only installed for the `test:browser` npm script. However, that same script is also used for Firefox ESR testing. This change makes Playwright dependencies installed only for cases where `WebKitHeadless` exists on the list of tested browsers. Closes jquerygh-5204 Ref jquerygh-5190 (cherry picked from commit e77bd9d)
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR gh-5190 added support for running tests on Playwright WebKit in CI. For efficiency reasons, Playwright dependencies are only installed for the
test:browsernpm script. However, that same script is also used for Firefox ESR testing.This change makes Playwright dependencies installed only for cases where
WebKitHeadlessexists on the list of tested browsers.Ref gh-5190
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com