Ajax: Support headers for script transport even when cross-domain
#5193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
Ajax
Needs review
Discuss in Meeting
mgol
changed the title
headers for script transport even when crossDomainheaders for script transport even when cross-domain
The AJAX script transport has two versions: XHR + `jQuery.globalEval` or appending a script tag (note that `jQuery.globalEval` also appends a script tag now, but inline). The former cannot support the `headers` option which has so far not been taken into account. For jQuery 3.x, the main consequence was the option not being respected for cross-domain requests. Since in 4.x we use the latter way more often, the option was being ignored in more cases. The transport now checks whether the `headers` option is specified and uses the XHR way unless `scriptAttrs` are specified as well. Fixes jquerygh-5142
mgol
force-pushed
the
ajax-script-headers-gh-5142
branch
from
890f0a6 to
2f867d9
Compare
mgol
commented
Jan 12, 2023
| } | ||
|
|
||
| // Install script dataType. Don't specify `content.script` so that an explicit | ||
| // Install script dataType. Don't specify `contents.script` so that an explicit |
Member
Author
There was a problem hiding this comment.
This is not related but since I was already modifying the nearby code... The comment was added in 025da4d and had the typo from the start.
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Jan 30, 2023
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
Agreed, just go the XHR route in this case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The AJAX script transport has two versions: XHR +
jQuery.globalEvalor appending a script tag (note thatjQuery.globalEvalalso appends a script tag now, but inline). The latter cannot support theheadersoption which has so far not been taken into account.For jQuery 3.x, the main consequence was the option not being respected for cross-domain requests. Since in 4.x we use the latter way more often, the option was being ignored in more cases.
The transport now checks whether the
headersoption is specified and uses the XHR way unlessscriptAttrsare specified as well.Fixes gh-5142
+5 bytes
Checklist