Core:Selector: Move jQuery.contains from the selector to the core module #5167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
contains-to-core
branch
from
3e50852 to
bc51c5d
Compare
gibson042
approved these changes
Dec 6, 2022
mgol
added
the
Discuss in Meeting
The `jQuery.contains` method is quite simple in jQuery 4+. On the other side, it's a dependency of the core `isAttached` util which is not ideal; moving it from the `selector` the `core` module resolves the issue.
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Dec 12, 2022
mgol
force-pushed
the
contains-to-core
branch
from
bc51c5d to
139c731
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
jQuery.containsmethod is quite simple in jQuery 4+. On the other side, it's a dependency of the coreisAttachedutil which is not ideal; moving it from theselectorthecoremodule resolves the issue.-1 byte
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com