Manipulation: Extract domManip to a separate file #5138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
Manipulation
Needs review
Discuss in Meeting
We've already had `buildFragment` extracted to a separate file long ago. `domManip` is quite a complex & crucial API and so far it has existed within the `manipulation.js` module. Extracting it makes the module shorter and easier to understand. A few comments / messages in tests have also been updated to not suggest there's a public `jQuery.domManip` API - it's been private since 3.0.0.
mgol
force-pushed
the
domManip-extraction
branch
from
4d681d6 to
db9652b
Compare
timmywil
removed
the
Discuss in Meeting
gibson042
approved these changes
Oct 10, 2022
timmywil
approved these changes
Oct 10, 2022
Member
Author
|
I experimented with backporting it to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've already had
buildFragmentextracted to a separate file long ago.domManipis quite a complex & crucial API and so far it has existed within themanipulation.jsmodule. Extracting it makes the module shorter and easier to understand.A few comments / messages in tests have also been updated to not suggest there's a public
jQuery.domManipAPI - it's been private since 3.0.0.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com