CSS: Return undefined for whitespace-only CSS variable values
#5120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
CSS
Needs review
Discuss in Meeting
3 tasks
The spec requires that CSS variable values are trimmed. In browsers that do this - mainly, Safari, but also Firefox if the value only has leading whitespace - we currently return `undefined`; in other browsers, we return an empty string as the logic to fall back to `undefined` happens before trimming. This commit adds another explicit callback to `undefined` to have it consistent across browsers. Also, more explicit comments about behaviors we need to work around in various browsers have been added. Ref jquerygh-5106
mgol
force-pushed
the
css-vars-whitespace
branch
from
8f953da to
31eeea5
Compare
mgol
removed
Discuss in Meeting
gibson042
approved these changes
Oct 3, 2022
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 3, 2022
…ry#5120) The spec requires that CSS variable values are trimmed. In browsers that do this - mainly, Safari, but also Firefox if the value only has leading whitespace - we currently return undefined; in other browsers, we return an empty string as the logic to fall back to undefined happens before trimming. This commit adds another explicit callback to `undefined` to have it consistent across browsers. Also, more explicit comments about behaviors we need to work around in various browsers have been added. Closes jquerygh-5120 Ref jquerygh-5106 (cherry picked from commit 7eb0019)
wmfgerrit
pushed a commit
to wikimedia/mediawiki
that referenced
this pull request
Aug 29, 2023
* Cross-browser: Improve selector engine to accomodate recent changes
in Safari and the cross-browser differences that introduces around `:has()`.
Note that the built-in `querySelectorAll()` sometimes throws
exceptions, which jQuery avoids from affecting your code.
* Cross-browser: Ensure that `$el.css('--some-variable')`
when the value is an empty string, returns undefined. Including in
current versions of Firefox and last years versions of Chrome, which
behave non-standardly.
jquery/jquery#5120
* Cross-browser: Avoid crash in Safari 16 when using `<template>`
elements, due to change in document.adoptNode() behaviour.
* Optimise size of various methods by removing code for obsolete browser
versions. Primarily, removal/inlining of Sizzle engine, and removal
of old code for Firefox versions that behaved differently around
SVG or XML elements.
About 4KB smaller in decoded size for JS parsing.
About 2KB smaller in transfer size.
* Optimise runtime of first `$()` call by removing obsolete support.
* Optimise manipulation methods like `append()`.
* Optimise focus events by using native events when possible/reliable.
Highlights from
https://blog.jquery.com/2022/12/13/jquery-3-6-2-released/
https://blog.jquery.com/2022/12/20/jquery-3-6-3-released-a-quick-selector-fix/
https://blog.jquery.com/2023/03/08/jquery-3-6-4-released-selector-forgiveness
https://blog.jquery.com/2023/05/11/jquery-3-7-0-released-staying-in-order/
https://blog.jquery.com/2023/08/28/jquery-3-7-1-released-reliable-table-row-dimensions/
Change-Id: I144069ce80127692b5c0ff91c4e55383f4013e2f
wmfgerrit
pushed a commit
to wikimedia/mediawiki
that referenced
this pull request
Aug 29, 2023
* Cross-browser: Improve selector engine to accomodate recent changes
in Safari and the cross-browser differences that introduces around `:has()`.
Note that the built-in `querySelectorAll()` sometimes throws
exceptions, which jQuery avoids from affecting your code.
* Cross-browser: Ensure that `$el.css('--some-variable')`
when the value is an empty string, returns undefined. Including in
current versions of Firefox and last years versions of Chrome, which
behave non-standardly.
jquery/jquery#5120
* Cross-browser: Avoid crash in Safari 16 when using `<template>`
elements, due to change in document.adoptNode() behaviour.
* Optimise size of various methods by removing code for obsolete browser
versions. Primarily, removal/inlining of Sizzle engine, and removal
of old code for Firefox versions that behaved differently around
SVG or XML elements.
About 4KB smaller in decoded size for JS parsing.
About 2KB smaller in transfer size.
* Optimise runtime of first `$()` call by removing obsolete support.
* Optimise manipulation methods like `append()`.
* Optimise focus events by using native events when possible/reliable.
Highlights from
https://blog.jquery.com/2022/12/13/jquery-3-6-2-released/
https://blog.jquery.com/2022/12/20/jquery-3-6-3-released-a-quick-selector-fix/
https://blog.jquery.com/2023/03/08/jquery-3-6-4-released-selector-forgiveness
https://blog.jquery.com/2023/05/11/jquery-3-7-0-released-staying-in-order/
https://blog.jquery.com/2023/08/28/jquery-3-7-1-released-reliable-table-row-dimensions/
Change-Id: I144069ce80127692b5c0ff91c4e55383f4013e2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The spec requires that CSS variable values are trimmed. In browsers that do
this - mainly, Safari, but also Firefox if the value only has leading
whitespace - we currently return
undefined; in other browsers, we returnan empty string as the logic to fall back to
undefinedhappens beforetrimming.
This PR adds another explicit callback to
undefinedto have it consistentacross browsers.
Also, more explicit comments about behaviors we need to work around in various
browsers have been added.
Ref gh-5106
+3 bytes
I verified that IE 11 passes all the tests with these changes.
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com