Skip to content

Selector: Inline Sizzle into the selector module: 3.x version #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 65 commits into from
Dec 14, 2022
Merged

Selector: Inline Sizzle into the selector module: 3.x version #5113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
72e09fa
Selector: Port Sizzle tests to jQuery
mgol Jun 26, 2019
26f7ac6
Selector: Inline Sizzle into the selector module
mgol May 1, 2019
8a8bfba
Selector: Apply `eslint --fix` to selector code
mgol May 1, 2019
aa41bd6
Selector: Remove obsolete workarounds, update support comments
mgol May 2, 2019
b25472d
Selector: Fix more ESLint violations
mgol May 2, 2019
6ad0b24
Selector: Reduce size by removing the assert helper
mgol May 2, 2019
27430a3
Selector: Fix new ESLint violations
mgol May 13, 2019
5c0bd6c
Selector: Reuse jQuery internal utils
mgol May 13, 2019
54c3e4b
Selector: ESLint: Fix no-nested-ternary; indent & one-var still broken
mgol May 15, 2019
d66ee02
Selector: Drop the `specified` attribute hack, it's not needed anymore
mgol May 15, 2019
0377bac
Selector: Add a support comment
mgol May 20, 2019
01fbb51
Tests: Rename "DOM Selector" to "jQuery Selector" in comments
mgol Jul 1, 2019
191380f
Selector: Get rid of the Sizzle name
mgol Jul 1, 2019
b99f16c
Tests: Don't rely on jQuery.find.compile in tests
mgol Jul 1, 2019
e82add2
Tests: Remove a leftover console.log
mgol Jul 3, 2019
8244ce3
Selector: Simplify code
mgol Jul 1, 2019
b197f3c
Selector: Extract jQuery.contains
mgol Jul 1, 2019
ebfb3fd
Selector: Extract jQuery.escapeSelector, move most find utils to jQuery
mgol Jul 1, 2019
45c6bb7
Selector: Move jQuery.text to Core, simplify it
mgol Jul 1, 2019
8e58b73
Selector: Save some size by using function declarations where possible
mgol Jul 1, 2019
6dbf560
Selector: Move isXMLDoc to Core
mgol Jul 1, 2019
7b98b31
Build: Remove obsolete ESLint overrides for dist/jquery.js
mgol Jul 1, 2019
e8be6fc
Build: Update AUTHORS.txt with authors from Sizzle
mgol Jul 3, 2019
0f742e6
Selector: Fix JSDoc
mgol Jul 3, 2019
f6a4833
Tests: Add a separate guard for positional selectors
mgol Jul 3, 2019
c7b4f25
Selector: Reduce selector-native.js
mgol Sep 7, 2022
09a063d
Selector: Restore docElem.webkitMatchesSelector for iOS 7
mgol Sep 7, 2022
92daf02
Selector: Bring back querySelectorAll shortcut usage
mgol Aug 9, 2019
577015e
Selector: Resolve the one-var ESLint error
mgol Sep 7, 2022
ebb312e
Selector: Allow whitespace after hex escapes in CSS identifiers
mgol Sep 7, 2022
f95c2c3
Selector: Leverage the :scope pseudo-class where possible
mgol Aug 19, 2019
60455d8
Selector: Inline selector/support back into selector, backport one test
mgol Aug 26, 2019
111c7cd
Selector: Don't use private jQuery copies of push, sort & splice
mgol Sep 8, 2022
c504ba0
Selector: Use shallow document comparisons to avoid IE/Edge crashes
mgol Sep 24, 2019
972634f
Selector: Use the nodeName util where possible to save size
mgol Sep 8, 2022
0e2e2b6
Selector: Make selectors with leading combinators use qSA again
mgol Sep 8, 2022
02c0b2f
Selector: Update most URLs to HTTPS
mgol Sep 8, 2022
5b542b2
Selector: Make empty attribute selectors work in IE again
mgol Sep 8, 2022
71a8529
Selector: Code style tweaks
mgol Sep 8, 2022
faaff1b
Tests: Run :enabled tests in selector-native
mgol Sep 8, 2022
1a84ffc
Core: Make jQuery.isXMLDoc accept falsy input
mgol Sep 8, 2022
047fd53
Selector: Differentiate between rtrim & rtrimCSS
mgol Sep 8, 2022
4ab9c95
Selector: Replace `#NUMBER` Trac issue references with `trac-NUMBER`
mgol Sep 8, 2022
e89d78a
Selector: Don't rely on splice being present on input
mgol Sep 8, 2022
bf78494
Tests: Fix one selector test
mgol Sep 8, 2022
f83e6e8
Selector: Fix the Sizzle test for form#lengthtest
mgol Sep 9, 2022
4daa77e
Selector: Fix :text pseudo-class & skip MutationObserver tests in IE 9
mgol Sep 9, 2022
4db4ec5
Selector: Fix iOS 7-9 issues, increase backwards compat with Sizzle
mgol Sep 12, 2022
e3773e9
Selector: Fix Android 4.0-4.3 issues
mgol Sep 12, 2022
4f78038
Tests: Skip MutationObserver tests in more legacy browsers
mgol Sep 13, 2022
f1bd375
Tests: Skip one broken selector test in IE 9
mgol Sep 13, 2022
e1d4783
Tests: Remove unneeded selector test code triggering setDocument
mgol Sep 19, 2022
6914c9c
Selector: Disable the ESLint indent rule in the ESLint config
mgol Sep 19, 2022
74de5e6
Selector: Use jQuery `:has` if `CSS.supports(selector(...))` buggy
mgol Sep 21, 2022
18241d2
Tests: Make selector-native tests work again
mgol Aug 8, 2022
9a29c8d
Tests: Backport a selector test fix for the Karma mode
mgol Sep 21, 2022
cd5f419
Selector: Backport Sizzle.attr tests to jQuery.find.attr tests
mgol Oct 7, 2022
5c1f3a7
Tests: Move QUnit.jQuerySelectors{,Pos} definitions up
mgol Oct 7, 2022
366b5af
Tests: Backport custom pseudos tests from Sizzle
mgol Oct 7, 2022
90f59ad
Selector:Manipulation: Fix DOM manip within template contents
mgol Nov 14, 2022
b262d26
Build: Rename the `-selector-full` flag to `-selector`
mgol Oct 10, 2022
d78dd1f
Selector: Fix querying on document fragments
mgol Nov 17, 2022
d00a091
Build: Fix the include mode
mgol Nov 17, 2022
b900d4e
Selector: Update some selector-native comments
mgol Oct 11, 2022
0715705
Tests: Indicate Firefox 106+ passes the `cssSupportsSelector` test
mgol Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Tests: Indicate Firefox 106+ passes the cssSupportsSelector test 
Firefox 106 adjusted to the spec mandating that `CSS.supports("selector(...)")`
uses non-forgiving parsing which makes it pass the relevant support test.

Closes gh-5141

(cherry picked from commit 716130e)
  • Loading branch information
@mgol
mgol committed Dec 13, 2022
commit 07157051e002eef9ff9631cd9edeb8778b1df6f0
2 changes: 1 addition & 1 deletion src/selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ function setDocument( node ) {
return document.querySelectorAll( ":scope" );
} );

// Support: Chrome 105+, Firefox 104+, Safari 15.4+
// Support: Chrome 105+, Firefox <106, Safari 15.4+
// Make sure forgiving mode is not used in `CSS.supports( "selector(...)" )`.
//
// `:is()` uses a forgiving selector list as an argument and is widely
Expand Down
29 changes: 28 additions & 1 deletion test/unit/support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,31 @@ testIframe(
sortStable: true
},
firefox: {
ajax: true,
boxSizingReliable: true,
checkClone: true,
checkOn: true,
clearCloneStyle: true,
cssSupportsSelector: true,
cors: true,
createHTMLDocument: true,
disconnectedMatch: true,
focusin: false,
getById: true,
noCloneChecked: true,
option: true,
optSelected: true,
pixelBoxStyles: true,
pixelPosition: true,
radioValue: true,
reliableMarginLeft: true,
reliableTrDimensions: false,
scope: true,
scrollboxSize: true,
sortDetached: true,
sortStable: true
},
firefox_102: {
ajax: true,
boxSizingReliable: true,
checkClone: true,
Expand Down Expand Up @@ -418,8 +443,10 @@ testIframe(
expected = expectedMap.chrome;
} else if ( /\b(?:9|10)\.\d+(\.\d+)* safari/i.test( userAgent ) ) {
expected = expectedMap.safari_9_10;
} else if ( /firefox\/(?:4\d|5\d|60)/i.test( userAgent ) ) {
} else if ( /firefox\/[456]\d\b/i.test( userAgent ) ) {
expected = expectedMap.firefox_60;
} else if ( /firefox\/(?:[789]\d|102)\b/i.test( userAgent ) ) {
expected = expectedMap.firefox_102;
} else if ( /firefox/i.test( userAgent ) ) {
expected = expectedMap.firefox;
} else if ( /android 4\.[0-3]/i.test( userAgent ) ) {
Expand Down