Core: Drop the root parameter of jQuery.fn.init #5096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The third parameter of `jQuery.fn.init` - `root` - was just needed to support `jQuery.sub`. Since this API has been removed in jQuery 1.9.0 and Migrate 3.x is not filling it in, this parameter is no longer needed. This parameter has never been documented but it's safer to remove it in a major update.
mgol
added
Needs review
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The third parameter of
jQuery.fn.init-root- was just needed to supportjQuery.sub. Since this API has been removed in jQuery 1.9.0 and Migrate 3.xis not filling it in, this parameter is no longer needed.
This parameter has never been documented but it's safer to remove it in a major
update.
It would still be good to put that in the upgrade guide.
-2 bytes
Checklist
New tests have been added to show the fix or feature works