Tests: Exclude tests based on compilation flags, not API presence #5046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
test-includesModule
branch
2 times, most recently
from
9f7468a to
eec6f01
Compare
mgol
force-pushed
the
test-includesModule
branch
from
eec6f01 to
55549a6
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Closes jquerygh-5046
mgol
force-pushed
the
test-includesModule
branch
from
55549a6 to
9ac0ef2
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Closes jquerygh-5046
mgol
force-pushed
the
test-includesModule
branch
from
9ac0ef2 to
39e7692
Compare
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Closes jquerygh-5046
mgol
force-pushed
the
test-includesModule
branch
from
39e7692 to
7b30faf
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Ref jquerygh-5046 (partially cherry picked from commit fae5fee)
2 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Ref jquerygh-5046 (partially cherry picked from commit fae5fee)
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Ref jquerygh-5046 (partially cherry picked from commit fae5fee)
mgol
added a commit
that referenced
this pull request
Jul 12, 2022
…x version) Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Closes gh-5071 Fixes gh-5069 Ref gh-5046 (partially cherry picked from commit fae5fee)
hossain-khan
added a commit
to hossain-khan/github-stats
that referenced
this pull request
Sep 23, 2022
Now prints ``` - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - PR: Tests: Exclude tests based on compilation flags, not API presence (jquery/jquery#5046) PR Available: May 23, 2022, 12:02:33 PM Review Time: {timmywil=35d 0h 25m 43s} PR Merged in: 35d 18h 36m 29s on Jun 28, 2022, 6:39:02 AM - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ```
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 11, 2023
PR jquerygh-5046 erroneously changed AJAX deprecated event alias usage in deprecated tests to `.on()` calls. This change reverses this mistake.
1 task
mgol
added a commit
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new test API,
includesModule. The method returns whethera particular module like "ajax" or "deprecated" is included in the current
jQuery build; it handles the slim build as well. The util was created so that
we don't treat presence of particular APIs to decide whether to run a test as
then if we accidentally remove an API, the tests would still not fail.
Fixes gh-5069
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com