CSS: Skip falsy values in addClass( array ), compress code#5003
Merged
Conversation
This change makes jQuery skip falsy values in `addClass( array )` & `removeClass( array )` instead of stopping iteration when the first falsy value is detected. This makes code like: ```js elem.addClass( [ "a", "", "b" ] ); ``` add both the `a` & `b` classes. The code was also optimized for size a bit. Fixes jquerygh-4998
mgol
added
the
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
timmywil
approved these changes
Jan 24, 2022
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
I like the change to use each.
mgol
added a commit
that referenced
this pull request
Jan 24, 2022
This change makes jQuery skip falsy values in `addClass( array )` & `removeClass( array )` instead of stopping iteration when the first falsy value is detected. This makes code like: ```js elem.addClass( [ "a", "", "b" ] ); ``` add both the `a` & `b` classes. The code was also optimized for size a bit so it doesn't increase the minified gzipped size. Fixes gh-4998 Closes gh-5003 (partially cherry picked from commit a338b40)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes jQuery skip falsy values in
addClass( array )&
removeClass( array )instead of stopping iteration when the first falsyvalue is detected. This makes code like:
add both the
a&bclasses.The code was also optimized for size a bit.
Fixes gh-4998
+0 bytes thanks to the optimizations 🎉; initially it was at +8 bytes. In
toggleClasswe now also avoid needlessly recomputing the array of classes.I'm yet to check how much can these optimizations be backported to 3.x-stable as we have some deprecated
toggleClasslogic there but I'll check after this lands.Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com