Skip to content

Docs: Replace #NUMBER Trac issue references with trac-NUMBER #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

mgol
Copy link
Member

@mgol mgol commented Jan 3, 2022

Summary

The GitHub UI treats #NUMBER as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
trac-NUMBER.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.

When this gets accepted, I'll submit a similar PR against the 3.x-stable branch to keep them aligned.

Checklist

Sorry, something went wrong.

@mgol mgol added Needs review Docs Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Jan 3, 2022
@mgol mgol requested a review from timmywil January 3, 2022 14:01
@mgol mgol self-assigned this Jan 3, 2022
@mgol mgol force-pushed the trac-issue-links branch from 3bf556f to 7f7e1d5 Compare January 3, 2022 14:02
@mgol mgol added this to the 4.0.0 milestone Jan 3, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.
@mgol mgol force-pushed the trac-issue-links branch from 7f7e1d5 to b90f140 Compare January 3, 2022 15:15
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this wasn't too tedious. Thanks!

@mgol mgol removed Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Jan 4, 2022
@mgol mgol merged commit 5d5ea01 into jquery:main Jan 4, 2022
@mgol mgol deleted the trac-issue-links branch January 4, 2022 15:27
mgol added a commit to mgol/jquery that referenced this pull request Jan 4, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.

Closes jquerygh-4993
Ref 5d5ea01
mgol added a commit to mgol/jquery that referenced this pull request Jan 4, 2022
This is a version of jquerygh-4993 for the `3.x-stable` branch.

The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.

Ref jquerygh-4993
Ref 5d5ea01
@mgol
Copy link
Member Author

mgol commented Jan 4, 2022

Landed on main in 5d5ea01. The 3.x-stable version is submitted as a separate PR: #4994.

@mgol
Copy link
Member Author

mgol commented Jan 4, 2022

@Mansalol Don’t spam our repo with random unrelated comments. This just wastes everyone’s time.

@jquery jquery deleted a comment from Mansalol Jan 4, 2022
mgol added a commit to mgol/jquery that referenced this pull request Jan 4, 2022
This is a version of jquerygh-4993 for the `3.x-stable` branch.

The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.

Ref jquerygh-4993
Ref 5d5ea01
mgol added a commit to mgol/jquery that referenced this pull request Jan 4, 2022
PR jquerygh-4993 changed a few too many issue references to `trac-NUMBER` ones. This
change fixes them. It also fixes a typo in one Trac issue number in selector
tests.

Ref jquerygh-4993
mgol added a commit that referenced this pull request Jan 12, 2022
This is a version of gh-4993 for the `3.x-stable` branch.

The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.

Closes gh-4994
Ref gh-4993
Ref 5d5ea01
mgol added a commit that referenced this pull request Jan 12, 2022
PR gh-4993 changed a few too many issue references to `trac-NUMBER` ones. This
change fixes them. It also fixes a typo in one Trac issue number in selector
tests.

Ref gh-4993
Closes gh-4995
mgol added a commit to mgol/jquery that referenced this pull request Sep 8, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Sep 12, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Sep 19, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Sep 21, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Oct 3, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Oct 4, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Nov 17, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Dec 1, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull request Dec 13, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

Ref jquerygh-4993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants