Docs: Remove links to Web Archive from source #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
web-archive-links-removal
branch
from
f9233cf to
c8fa248
Compare
timmywil
approved these changes
Jan 3, 2022
|
any idea when this fix will get in ? which version is this expected to be on ? is there a way to get a 3.6.1 with just this change ? |
Neither of the removed links is crucial; one of them refers to a site that has since started being malicious; while the Web Archive links remain safe, some scanners warn about such links. Removing them is the safest thing to do. Fixes jquerygh-4981
mgol
force-pushed
the
web-archive-links-removal
branch
from
c8fa248 to
ec5d22a
Compare
|
@sileclercq It will be included in jQuery 3.6.1 as can be seen by looking at the Milestone field. We don't plan any special release just with this patch as this is not an actual vulnerability. |
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Jan 6, 2022
3 tasks
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Jan 7, 2022
3 tasks
timmywil
added a commit
that referenced
this pull request
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Neither of the removed links is crucial; one of them refers to a site that has
since started being malicious; while the Web Archive links remain safe, some
scanners warn about such links. Removing them is the safest thing to do.
Fixes gh-4981
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com