Skip to content

CSS: Justify use of rtrim on CSS property values #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2022
Merged

CSS: Justify use of rtrim on CSS property values #4956

merged 1 commit into from
Jan 3, 2022

Conversation

gibson042
Copy link
Member

CSS does not acknowledge carriage return or form feed characters as whitespace but it does replace them with whitespace, making it acceptable to use rtrim.

mgol
mgol approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it reaches the same end goal via different means? Phew! LGTM.

@mgol mgol mentioned this pull request Oct 18, 2021
Closed
@mgol mgol merged commit 655c0ed into jquery:main Jan 3, 2022
mgol pushed a commit that referenced this pull request Jan 3, 2022
@gibson042 @mgol
CSS: Justify use of rtrim on CSS property values
a1373e2 
CSS does not acknowledge carriage return or form feed characters
as whitespace but it does replace them with whitespace, making it
acceptable to use `rtrim`.

Closes gh-4956

(cherry picked from commit 655c0ed)
@mgol mgol added this to the 3.6.1 milestone Jan 3, 2022
@mgol mgol added the CSS label Jan 3, 2022
@jquery jquery deleted a comment from Mansalol Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil

@mgol mgol

Assignees
No one assigned
Labels
CSS
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @timmywil @mgol