CSS: Don't special-case backslashes when trimming CSS Custom Properties #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic from PR jquerygh-4930 re-used the `rtrim` regex from the selector module but selectors have special escaping rules which means whitespace following a backslash character would not get trimmed. This change splits the logic at the unfortunate but necessary cost of size. Ref jquerygh-4926 Ref jquerygh-4930
mgol
added
CSS
Needs review
Blocker
Discuss in Meeting
4 tasks
|
As discussed at the today's team meeting, this is not a correct change. Whitespace is getting trimmed after tokenization and some tokens contain a trailing whitespace. We still need to discuss whether the current solution from #4930 is fine or if it needs more iterations but this PR is not what we need. |
mgol
removed
Needs review
Blocker
Discuss in Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original logic from PR gh-4930 re-used the
rtrimregex from the selectormodule but selectors have special escaping rules which means whitespace
following a backslash character would not get trimmed.
This change splits the logic at the unfortunate but necessary cost of size.
Ref gh-4926
Ref gh-4930
This is at +44 bytes now but together with gh-4930 where it should be included it's at about half that.
When this lands, I'll CP gh-4930 together with this PR to
3.x-stable.Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com