Offset: Increase search depth when finding the 'real' offset parent #4861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, I thought I had fixed that failing test 😓😓 |
Minimaximize
force-pushed
the
jquery-position-fix
branch
from
2ca829e to
3dd9126
Compare
|
Finally tracked down the docs describing why the licence check was indeterminate - Fixed the erroneous author attributions for my commits |
|
Closing & re-opening the PR to trigger the EasyCLA check... |
gibson042
approved these changes
Mar 25, 2024
| } | ||
| if ( offsetParent && offsetParent !== elem && offsetParent.nodeType === 1 ) { | ||
| if ( offsetParent && offsetParent !== elem && offsetParent.nodeType === 1 && | ||
| jQuery.css( offsetParent, "position" ) !== "static" ) { | ||
|
|
||
| // Incorporate borders into its offset, since they are outside its content origin | ||
| parentOffset = jQuery( offsetParent ).offset(); |
There was a problem hiding this comment.
While we're here making changes, we could also account for scrolling.
- // Incorporate borders into its offset, since they are outside its content origin
+ // The origin against which we will be returning a relative position is the absolute offset
+ // of offsetParent, plus the top/left width of its borders (since they are outside offsetParent's
+ // content origin), minus its top/left scroll position (which has already affected element
+ // absolute offset and should not be counted twice)
parentOffset = jQuery( offsetParent ).offset();
- parentOffset.top += jQuery.css( offsetParent, "borderTopWidth", true );
- parentOffset.left += jQuery.css( offsetParent, "borderLeftWidth", true );
+ parentOffset.top += jQuery.css( offsetParent, "borderTopWidth", true ) - offsetParent.scrollTop;
+ parentOffset.left += jQuery.css( offsetParent, "borderLeftWidth", true ) - offsetParent.scrollLeft;
There was a problem hiding this comment.
I guess we should add some tests for this part of the behavior then as well.
There was a problem hiding this comment.
Extracted to #5468. @gibson042 if you have nothing against, I'd merge this PR as-is and track the remaining changes via #5468. Let me know what you think.
mgol
added
the
Discuss in Meeting
mgol
changed the title
|
Followup work extracted to #5468 per the last team meeting. |
mgol
removed
Discuss in Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continue searching for the next positioned offsetParent (or the document) when calculating
position().This fixes the seemingly inconsistent behaviour that occurred when calling
position()on elements inside tables; for which the offsetParent changes based on itspositioncss property. e.gPreviously
$('#static').position()was returning the position relative to the containing<td>element, while$('#relative').position()was returning the position relative to#positioned-containerNow, both elements return their position relative to the containing
#positioned-containerChecklist