Tests: Fix tests for not auto-executing scripts without dataType #4824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
Needs review
Tests
Discuss in Meeting
Two issues are fixed in testing for responses with a script Content-Type not getting auto-executed unless an explicit `dataType: "script"` is provided: * the test is now using a correct "text/javascript" Content-Type; it was using "text/html" until now which doesn't really check if the fix works * the Node.js based version of the tests didn't account for an empty `header` query string parameter Ref jquerygh-2432 Ref jquerygh-2588 Ref 39cdb8c
mgol
force-pushed
the
ajax-script-crossorigin-test-gh-2432
branch
from
51358da to
5f57ee5
Compare
timmywil
removed
the
Discuss in Meeting
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 11, 2021
Two issues are fixed in testing for responses with a script Content-Type not getting auto-executed unless an explicit `dataType: "script"` is provided: * the test is now using a correct "text/javascript" Content-Type; it was using "text/html" until now which doesn't really check if the fix works * the Node.js based version of the tests didn't account for an empty `header` query string parameter Closes jquerygh-4824 Ref jquerygh-2432 Ref jquerygh-2588 Ref 39cdb8c (cherry picked from commit d38528b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two issues are fixed in testing for responses with a script Content-Type not
getting auto-executed unless an explicit
dataType: "script"is provided:"text/html" until now which doesn't really check if the fix works
headerquery string parameter
Ref gh-2432
Ref gh-2588
Ref 39cdb8c
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com