Skip to content

Core: Make jQuery.isXMLDoc accept falsy input #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Core: Make jQuery.isXMLDoc accept falsy input #4814

merged 1 commit into from
Dec 7, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Dec 1, 2020 •
edited
Loading

Summary

Fixes gh-4782

Sizzle version for jQuery 3.x: jquery/sizzle#474.

Checklist

Sorry, something went wrong.

@mgol mgol added Core Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Dec 1, 2020
@mgol mgol added this to the 4.0.0 milestone Dec 1, 2020
@mgol mgol self-assigned this Dec 1, 2020
mgol added a commit to mgol/sizzle that referenced this pull request Dec 1, 2020
@mgol
Core: Make Sizzle.isXML accept falsy input
e377b1c 
Fixes jquery/jquery#4782
Ref jquery/jquery#4814
@mgol mgol mentioned this pull request Dec 1, 2020
Merged
mgol added a commit to mgol/sizzle that referenced this pull request Dec 1, 2020
@mgol
Core: Make Sizzle.isXML accept falsy input
1b4f3a6 
Fixes jquery/jquery#4782
Ref jquery/jquery#4814
@mgol mgol mentioned this pull request Dec 1, 2020
Closed
@mgol mgol force-pushed the isXML-falsy-check-4782 branch from f0eec52 to a841a14 Compare December 1, 2020 16:27
@mgol mgol force-pushed the isXML-falsy-check-4782 branch from a841a14 to ae1985d Compare December 1, 2020 16:29
mgol added a commit to mgol/sizzle that referenced this pull request Dec 1, 2020
@mgol
Core: Make Sizzle.isXML accept falsy input
8ea37ad 
Fixes jquery/jquery#4782
Ref jquery/jquery#4814
timmywil
timmywil approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Dec 7, 2020
mgol added a commit to jquery/sizzle that referenced this pull request Dec 7, 2020
@mgol
Core: Make Sizzle.isXML accept falsy input
9987cb3 
Fixes jquery/jquery#4782
Closes gh-474
Ref jquery/jquery#4814
@mgol mgol merged commit fd42109 into jquery:master Dec 7, 2020
@mgol mgol deleted the isXML-falsy-check-4782 branch December 7, 2020 20:09
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2021
Closed
mgol added a commit to mgol/jquery that referenced this pull request Sep 8, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
5ae5b85 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Sep 12, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
9e1cd58 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Sep 19, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
44d3d44 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Sep 21, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
4364682 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Oct 3, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
154f9ad 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Oct 4, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
2b4290f 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Nov 17, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
976bc7c 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Dec 1, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
2ae782c 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
mgol added a commit to mgol/jquery that referenced this pull request Dec 13, 2022
@mgol
Core: Make jQuery.isXMLDoc accept falsy input
1a84ffc 
Ref jquerygh-4782
Ref jquerygh-4814
Ref jquery/sizzle#474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmethvin dmethvin

@timmywil timmywil

Assignees

@mgol mgol

Labels
Core
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

isXMLDoc() - Uncaught TypeError: Cannot read property 'namespaceURI' of undefined
3 participants
@mgol @dmethvin @timmywil