Attributes: Drop the toggleClass(boolean|undefined) signature
#4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of this signature is not intuitive, especially if classes are manipulated via other ways between `toggleClass` calls. Fixes jquerygh-3388
|
Diff best viewed with whitespace changes hidden: https://github.com/jquery/jquery/pull/4766/files?w=1 |
Krinkle
approved these changes
Aug 17, 2020
mgol
added
the
Discuss in Meeting
timmywil
approved these changes
Aug 31, 2020
timmywil
removed
the
Discuss in Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attributes: Drop the
toggleClass(boolean|undefined)signature.The behavior of this signature is not intuitive, especially if classes are
manipulated via other ways between
toggleClasscalls.Fixes gh-3388
-86 bytes
Checklist
New tests have been added to show the fix or feature works(tests have been removed)toggleClass(boolean)&toggleClass(undefined)are removed in 4.0 api.jquery.com#1172