Fixes #9521. Prioritize #id over <tag> to avoid XSS via location.hash. #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice test! Everything is reproduced as I expect it should. |
dmethvin
added a commit
that referenced
this pull request
Aug 25, 2011
Fixes #9521. Prioritize #id over <tag> to avoid XSS via location.hash.
markelog
pushed a commit
to markelog/jquery
that referenced
this pull request
Jan 11, 2012
Fixes #9521. Prioritize #id over <tag> to avoid XSS via location.hash.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test had to be async, unfortunately. This patch causes Sizzle to reject a string like
"#<img ...>"by throwing an error: "Syntax error, unrecognized expression: <" which is probably a good thing since this is a security issue.