Build: Fix commitplease husky config #4737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jquerygh-4735 Signed-off-by: Beatriz Rezener <beatrizrezener@gmail.com>
mgol
requested changes
Jun 24, 2020
package.json
Outdated
| @@ -77,7 +77,8 @@ | |||
| "test:no-deprecated": "grunt test:prepare && grunt custom:-deprecated && grunt karma:main", | |||
| "test:slim": "grunt test:prepare && grunt custom:slim && grunt karma:main", | |||
| "test": "npm run test:slim && npm run test:no-deprecated && grunt && grunt test:slow && grunt karma:main && grunt karma:esmodules && grunt karma:amd", | |||
| "jenkins": "npm run test:browserless" | |||
| "jenkins": "npm run test:browserless", | |||
| "commitmsg": "commitplease .git/COMMIT_EDITMSG" | |||
There was a problem hiding this comment.
I think I'd prefer not going through npm scripts for some things and the husky.hooks field below for others. Moving the command should not be necessary, just fixing the command, I think.
Whatever you try, please verify locally that the check properly fires.
There was a problem hiding this comment.
Sorry, I've tested and in fact we just need change the hook command, there is no why change to npm script. Thank you!
Fixes jquerygh-4735 Signed-off-by: Beatriz Rezener <beatrizrezener@gmail.com>
mgol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-4735
As defined in commitplease README:
Changed hook
commit-msgtocommitplease .git/COMMIT_EDITMSGChecklist
Signed-off-by: Beatriz Rezener beatrizrezener@gmail.com