Skip to content

Build: Update dependencies #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

Build: Update dependencies #4732

merged 1 commit into from
Jul 15, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Jun 8, 2020 •
edited
Loading

Summary

This also resolves a security warning from GitHub about a vulnerable request
version - the new testswarm package version depends on a fixed request.

Checklist

Sorry, something went wrong.

@mgol mgol added this to the 4.0.0 milestone Jun 8, 2020
@mgol mgol self-assigned this Jun 8, 2020
@mgol mgol requested a review from timmywil June 8, 2020 19:27
@mgol mgol removed the Needs review label Jun 8, 2020
@mgol mgol removed the request for review from timmywil June 8, 2020 19:34
@mgol mgol marked this pull request as draft June 8, 2020 19:42
@mgol mgol force-pushed the updates branch 2 times, most recently from 385890e to 1625ad1 Compare June 8, 2020 21:15
@mgol mgol marked this pull request as ready for review June 8, 2020 21:24
@mgol mgol requested a review from timmywil June 8, 2020 21:24
@mgol mgol force-pushed the updates branch 2 times, most recently from cc54dc3 to c752708 Compare June 10, 2020 16:54
@mgol
Copy link
Member Author

mgol commented Jun 10, 2020

There's a bug in the latest node-testswarm version that I'm fixing in jzaefferer/node-testswarm#17; going back to draft status with this PR until this is resolved.

@mgol mgol marked this pull request as draft June 10, 2020 19:52
@mgol mgol removed the request for review from timmywil June 10, 2020 19:52
@mgol mgol removed the Needs review label Jun 10, 2020
@mgol mgol marked this pull request as ready for review June 11, 2020 22:15
@mgol mgol requested a review from timmywil June 11, 2020 22:15
@mgol
Copy link
Member Author

mgol commented Jun 11, 2020 •
edited
Loading

The node-testswarm bug is now fixed in 1.1.2, I updated the PR.

@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Jun 24, 2020
timmywil
timmywil approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Jul 13, 2020
@mgol
Build: Update dependencies
4eb4366 
This also resolves a security warning from GitHub about a vulnerable `request`
version - the new `testswarm` package version depends on a fixed `request`.
@mgol mgol merged commit b502866 into jquery:master Jul 15, 2020
@mgol mgol deleted the updates branch July 15, 2020 14:17
@mgol mgol removed the Needs review label Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil

@gibson042 gibson042

@3imed-jaberi 3imed-jaberi

Assignees

@mgol mgol

Labels
Build
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgol @timmywil @gibson042 @3imed-jaberi