Skip to content

Tests: Remove remaining obsolete jQuery.cache references #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented May 13, 2020

Summary

Tests: Remove remaining obsolete jQuery.cache references

PR gh-4586 removed some of those but not all.

Ref gh-4586

Checklist

Sorry, something went wrong.

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that code was put in shortly after I started contributing. It caught and prevented many memory leaks.

@mgol mgol added Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. and removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels May 18, 2020
@mgol mgol added this to the 3.6.0 milestone May 18, 2020
@mgol mgol merged commit d96111e into jquery:master May 18, 2020
@mgol mgol deleted the no-jq-cache branch May 18, 2020 16:43
mgol added a commit that referenced this pull request May 18, 2020
PR gh-4586 removed some of those but not all.

Closes gh-4715
Ref gh-4586

(cherry picked from commit d96111e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants