Build: Followups after introducing ES modules compiled via Rollup #4705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
rollup-build-followups
branch
from
68beb4b to
efc2db2
Compare
dmethvin
approved these changes
May 4, 2020
Member
dmethvin
left a comment
dmethvin
left a comment
There was a problem hiding this comment.
LGTM, would be nice to update the comment to point to trac.
timmywil
approved these changes
May 4, 2020
This commit cleans up a few comments & configurations that are out of date after the migration to ES modules backed by a Rollup-based compilation.
This will preserve a more similar structure to the one on 3.x-stable where the body of the main `define` wrapper is not indented.
Co-authored-by: Dave Methvin <[email protected]>
mgol
force-pushed
the
rollup-build-followups
branch
from
dfe120b to
573a840
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up a few comments & configurations that are out of date
after the migration to ES modules backed by a Rollup-based compilation.
Also, de-indent AMD modules. This will preserve a more similar
structure to the one on 3.x-stable where the body of the main
definewrapper is not indented.
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com