CSS: Include show, hide & toggle methods in the jQuery slim build
#4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
CSS
Needs review
Discuss in Meeting
|
This PR is needed to make Migrate tests pass against jQuery master: http://swarm.jquery.org/job/9751 |
timmywil
approved these changes
May 4, 2020
mgol
removed
Discuss in Meeting
The `show()`, `hide()` & `toggle()` methods were included in the 3.x jQuery slim build. The jQuery master build accidentally started to exclude them as they were only imported in the effects module and the new Rollup-based build system follows the module dependency graph when excluding modules. To resolve the issue, import the `css/showHide.js` file directly in the main `jquery.js` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
show(),hide()&toggle()methods were included in the 3.x jQuery slimbuild. The jQuery master build accidentally started to exclude them as they were
only imported in the effects module and the new Rollup-based build system
follows the module dependency graph when excluding modules.
To resolve the issue, import the
css/showHide.jsfile directly in the mainjquery.jsfile.We don't really have tests for what gets into the slim build so I didn't add anything.
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com