Build: Append .eslintignore paths to grunt eslint paths #4689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to turn off the `quiet` option which was suppressing warnings. We can also set `maxWarnings` to 0 now that aren't any.
mgol
reviewed
Apr 27, 2020
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
I need to test it locally but it looks like a great idea, thanks!
My only worry is ESLint 7 will introduce a new ESLint class that will have async methods, deprecating the current CLIEngine so we'll need to think what to do in such a case:
https://eslint.org/blog/2020/02/whats-coming-in-eslint-7.0.0
Contributor
Author
|
I suppose if it gets dropped in ESLint 8 the grunt task can be made async. |
Contributor
Author
|
(or at that point just drop |
mgol
approved these changes
Jul 22, 2020
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
ESLint 7 is out and it still supports the CLIEngine. Looks good to me!
mgol
added
the
Discuss in Meeting
Member
|
Landed, thanks! |
mgol
removed
Discuss in Meeting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows us to turn off the
quietoption which was suppressing warnings.We can also set
maxWarningsto 0 now that aren't any, which will catchreportUnusedDisableDirectiveswarnings.Checklist