Data: Make the data object a regular object again #4666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in jquerygh-4603 made the object returned by `elem.data()` a prototype-less object. That's a desired change to support keys colliding with Object.prototype properties but it's also a breaking change so it has to wait for jQuery 4.0.0. A 3.x-only test was added to avoid breaking it in the future on this branch. Fixes jquerygh-4665 Ref jquerygh-4603
mgol
added
Discuss in Meeting
|
LGTM2 |
dmethvin
approved these changes
Apr 13, 2020
|
Dear @mgol, I can confirm that this fix addresses an issue I was having with Hoping a fix can be released (relatively) quickly :) Cheers, |
NicolasCARPi
added a commit
to elabftw/elabftw
that referenced
this pull request
Apr 16, 2020
alee
added a commit
to comses/comses.net
that referenced
this pull request
Apr 16, 2020
jquery 3.5.0 has a regression with bootstrap collapse (among others) pinning to ~3.4.1 (to allow minor patch releases) until jquery/jquery#4666 is merged + released
yaroslavmo
pushed a commit
to dreamfactorysoftware/df-admin-app
that referenced
this pull request
Apr 20, 2020
- The issue refers to jquery 3.5.0 - After jquery/jquery#4666 is merged we can go back to using latest jquery
volodymyrpoli
pushed a commit
to dreamfactorysoftware/df-admin-app
that referenced
this pull request
Apr 20, 2020
- The issue refers to jquery 3.5.0 - After jquery/jquery#4666 is merged we can go back to using latest jquery
mgol
removed
Discuss in Meeting
|
@mgol Thanks for fixing this issue! BTW is there a plan to include this fix into the next release and is there an Estimated release date yet? Thanks. |
Member
Author
|
@AttitudeL The fix will be included in 3.5.1. We’ll try to get the release out soon. That mostly depends on our available time, though, so I cannot provide any specific date. |
fetus-hina
added a commit
to fetus-hina/stat.ink
that referenced
this pull request
May 1, 2020
jQuery 3.5.0 と Bootstrap 3 の組み合わせでは、次の問題により アコーディオンが動作しない: jquery/jquery#4665 この問題を修正する Pull Request は merge されたものの、 3.5.1 は現時点ではリリースされていない。 jquery/jquery#4666 この commit では jQuery 3.5.0 に当該パッチを当てることで、 3.5.1 を待たず jQuery のバージョンアップを行う。 (3.5.0 ではセキュリティフィックスが入っているので一応早めに上げたい）
hwelsters
pushed a commit
to hwelsters/comses.net
that referenced
this pull request
May 10, 2023
jquery 3.5.0 has a regression with bootstrap collapse (among others) pinning to ~3.4.1 (to allow minor patch releases) until jquery/jquery#4666 is merged + released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the data object a regular object again.
The change in gh-4603 made the object returned by
elem.data()a prototype-lessobject. That's a desired change to support keys colliding with Object.prototype
properties but it's also a breaking change so it has to wait for jQuery 4.0.0.
A 3.x-only test was added to avoid breaking it in the future on this branch.
Fixes gh-4665
Ref gh-4603
-1 byte
Checklist