Build:Event: Make sure all source modules' exports are used #4648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To achieve that, use `eslint-plugin-import`'s `no-unused-modules` rule. Also, explicitly import `event/trigger.js` from `jquery.js`; so far it was only imported from ajax.js, making it mistakenly skipped in the `custom:slim,-deprecated` build.
mgol
added
the
Discuss in Meeting
dmethvin
approved these changes
Jun 1, 2020
Member
|
So I wonder, tho, if we should leave |
timmywil
approved these changes
Jun 1, 2020
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
Discussed in meeting. This is good to go.
mgol
added
Event
and removed
Discuss in Meeting
mgol
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure all source modules' exports are used.
To achieve that, use
eslint-plugin-import'sno-unused-modulesrule.Also, explicitly import
event/trigger.jsfromjquery.js; so far it was onlyimported from ajax.js, making it mistakenly skipped in the
custom:slim,-deprecatedbuild.-5 bytes! :)
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com